Issue 396883002: Implementation for the 'search.findMemberReferences' API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396883002: Implementation for the 'search.findMemberReferences' API. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implementation for the 'search.findMemberReferences' API. It seems that implementation if very simple, so I will put it inline instead of a separate file. The previous 'search.findMemberDeclarations' CL will be updated before commit. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38285

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -50 lines)			Patch
M	pkg/analysis_server/lib/src/search/search_domain.dart	View	3 chunks	+21 lines, -13 lines	0 comments	Download
D	pkg/analysis_server/lib/src/search/top_level_declarations.dart	View	1 chunk	+0 lines, -34 lines	0 comments	Download
A	pkg/analysis_server/test/search/member_references_test.dart	View	1 chunk	+126 lines, -0 lines	1 comment	Download
M	pkg/analysis_server/test/search/test_all.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/396883002/diff/1/pkg/analysis_server/test/search/member_references_test.dart File pkg/analysis_server/test/search/member_references_test.dart (right): https://codereview.chromium.org/396883002/diff/1/pkg/analysis_server/test/search/member_references_test.dart#newcode91 pkg/analysis_server/test/search/member_references_test.dart:91: assertHasRef(SearchResultKind.WRITE, 'foo = 1;', false); It would be ...

6 years, 5 months ago (2014-07-16 13:52:37 UTC) #2

scheglov

6 years, 5 months ago (2014-07-16 15:33:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38285 (presubmit successful).

Expand Messages | Collapse Messages