Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 396803003: Serialize scopes according to semantic structure. (Closed)

Created:
6 years, 5 months ago by ahe
Modified:
6 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch, gbracha
Visibility:
Public.

Description

Serialize scopes according to semantic structure. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39137

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add documentation as suggested by Johnni. #

Patch Set 3 : Merged with r39136 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -36 lines) Patch
M dart/site/try/poi/poi.dart View 1 2 5 chunks +114 lines, -19 lines 0 comments Download
A dart/tests/try/poi/data/private.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A dart/tests/try/poi/data/subclass.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M dart/tests/try/poi/serialize_test.dart View 3 chunks +459 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
@Gilad: this is what we discussed about having separate scopes for "class side" and "instance ...
6 years, 5 months ago (2014-07-16 11:34:20 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/396803003/diff/1/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/396803003/diff/1/dart/site/try/poi/poi.dart#newcode312 dart/site/try/poi/poi.dart:312: class ScopeInformationVisitor extends ElementVisitor/* <void> */ { Comments ...
6 years, 5 months ago (2014-07-18 10:33:07 UTC) #2
ahe
Thank you, Johnni! https://codereview.chromium.org/396803003/diff/1/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/396803003/diff/1/dart/site/try/poi/poi.dart#newcode312 dart/site/try/poi/poi.dart:312: class ScopeInformationVisitor extends ElementVisitor/* <void> */ ...
6 years, 4 months ago (2014-08-12 13:53:47 UTC) #3
ahe
Committed patchset #3 manually as 39137 (presubmit successful).
6 years, 4 months ago (2014-08-12 13:54:32 UTC) #4
Johnni Winther
6 years, 4 months ago (2014-08-12 14:00:49 UTC) #5
Message was sent while issue was closed.
Documentation LGTM

Powered by Google App Engine
This is Rietveld 408576698