Work around a Gyp bug by creating a stamp file for the http package.

Work around a Gyp bug by creating a stamp file for the http package.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38263

[Bob Nystrom, 2014-07-15 22:50:30]

lgtm

[nweiz, 2014-07-15 22:55:02]

Committed patchset #1 manually as r38263 (presubmit successful).

[ahe, 2014-08-06 14:15:51]

Please ask for help *before* you submit GYP changes, and please don't submit GYP
changes that haven't been reviewed by one of ricow, kustermann, or me.

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp#newcode39
pkg/pkg.gyp:39: 'target_name': 'pub_packages',
Adding another target here isn't necessary.

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp#newcode46
pkg/pkg.gyp:46: '<(SHARED_INTERMEDIATE_DIR)/http_files.stamp',
This target is always run because this file doesn't exist.

To depend on a generated file you need to do two things.

Assume you in target "T1" have action "A1" which generates file "foo.txt", and
you in target "T2" have action "A2" which depends on "foo.txt:

1. List the file as an input of action "A2" (which you have done).

2. List the target "T1" as a dependency of target "T2" (that is missing).

[ahe, 2014-08-06 14:25:55]

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp#newcode46
pkg/pkg.gyp:46: '<(SHARED_INTERMEDIATE_DIR)/http_files.stamp',
On 2014/08/06 14:15:51, ahe wrote:
> This target is always run because this file doesn't exist.

That's not correct. It is the action "make_pub_packages" that is always being
run.

Regardless, the problem is with this line. If I manually create
xcodebuild/DerivedSources/ReleaseIA32/http_files.stamp, the action
"make_pub_packages" isn't run when it isn't necessary.

[nweiz, 2014-08-06 21:18:05]

Follow-up CL: https://codereview.chromium.org/451503002/

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp#newcode39
pkg/pkg.gyp:39: 'target_name': 'pub_packages',
On 2014/08/06 14:15:51, ahe wrote:
> Adding another target here isn't necessary.

Why not? We need to refer to this target as distinct from pkg_packages, don't
we?

https://codereview.chromium.org/396753006/diff/1/pkg/pkg.gyp#newcode46
pkg/pkg.gyp:46: '<(SHARED_INTERMEDIATE_DIR)/http_files.stamp',
On 2014/08/06 14:25:55, ahe wrote:
> On 2014/08/06 14:15:51, ahe wrote:
> > This target is always run because this file doesn't exist.
> 
> That's not correct. It is the action "make_pub_packages" that is always being
> run.
> 
> Regardless, the problem is with this line. If I manually create
> xcodebuild/DerivedSources/ReleaseIA32/http_files.stamp, the action
> "make_pub_packages" isn't run when it isn't necessary.

Done.