Issue 396733008: Audiocontext test is not failing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396733008: Audiocontext test is not failing. (Closed)

Created:
6 years, 5 months ago by floitsch

Modified:
6 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Audiocontext test is not failing. Committed: https://code.google.com/p/dart/source/detail?r=38279

Patch Set 1 #

Patch Set 2 : Actually the test is flaky. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/html/html.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

Not sure why, but the test consistently succeeds now. Updating status file. TBR.

6 years, 5 months ago (2014-07-16 09:38:08 UTC) #1

floitsch

Committed patchset #2 manually as r38279 (presubmit successful).

6 years, 5 months ago (2014-07-16 11:27:56 UTC) #4

Emily Fortuna

6 years, 5 months ago (2014-07-16 17:38:41 UTC) #5

Message was sent while issue was closed.

Thank you for doing this. I adjusted the test because Firefox does not throw
when you set invalid values; it simply ignores them, where chrome throws an
exception. I fixed firefox, and adjusted the test so it'd run there, but didn't
realize this was the source of some of the failures in drt as well.

Expand Messages | Collapse Messages