Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 396383002: More integration tests for analysis server. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More integration tests for analysis server. This covers everything in the "server" domain except for server.error (which is difficult to test since it should only occur in the event of a server bug). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=38319

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -21 lines) Patch
M pkg/analysis_server/test/integration/analysis_error_inttest.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 9 chunks +62 lines, -11 lines 0 comments Download
A pkg/analysis_server/test/integration/server_domain_inttest.dart View 1 chunk +126 lines, -0 lines 2 comments Download
A + pkg/analysis_server/test/integration/test_all.dart View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-16 20:52:15 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/396383002/diff/1/pkg/analysis_server/test/integration/server_domain_inttest.dart File pkg/analysis_server/test/integration/server_domain_inttest.dart (right): https://codereview.chromium.org/396383002/diff/1/pkg/analysis_server/test/integration/server_domain_inttest.dart#newcode86 pkg/analysis_server/test/integration/server_domain_inttest.dart:86: // that this notification should only occur in ...
6 years, 5 months ago (2014-07-16 21:47:32 UTC) #2
Paul Berry
https://codereview.chromium.org/396383002/diff/1/pkg/analysis_server/test/integration/server_domain_inttest.dart File pkg/analysis_server/test/integration/server_domain_inttest.dart (right): https://codereview.chromium.org/396383002/diff/1/pkg/analysis_server/test/integration/server_domain_inttest.dart#newcode86 pkg/analysis_server/test/integration/server_domain_inttest.dart:86: // that this notification should only occur in the ...
6 years, 5 months ago (2014-07-16 23:43:25 UTC) #3
Paul Berry
6 years, 5 months ago (2014-07-16 23:46:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698