Issue 39613002: Close file watcher when target is deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39613002: Close file watcher when target is deleted. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Close file watcher when target is deleted. BUG=http://code.google.com/p/dart/issues/detail?id=14374 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29159

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -12 lines)			Patch
M	runtime/bin/file_patch.dart	View	1	5 chunks	+16 lines, -6 lines	0 comments	Download
M	runtime/bin/file_system_watcher.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/file_system_watcher_linux.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_system_watcher_test.dart	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	tools/create_sdk.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Søren Gjesse

lgtm, but you should update the documentation with information on: 1. You get a delete ...

7 years, 2 months ago (2013-10-24 08:00:13 UTC) #2

Anders Johnsen

7 years, 2 months ago (2013-10-24 08:12:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29159 (presubmit successful).