Allows building debian packages for ARM.

Allows building debian packages for ARM.

This change adds arm as a possible architecture to
the create_debian_packages.py script and additionally
adds a toolchain flag so that arm packages can be
built using different cross-compilers that target
different ARM versions. The specified cross-compiler
is passed on to the debian/rules file through an
environment variable.

R=ricow@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39291

[ricow1, 2014-07-30 12:47:06]

bot code lgtm, I don't know anything about the rules, please let sgjesse review
that

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
File tools/linux_dist_support/debian/rules (right):

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:59: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
I don't know if we shoujld use tabs like you do above or not,but at least we
should be consistent

[Søren Gjesse, 2014-08-05 15:20:30]

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
File tools/create_debian_packages.py (right):

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:88: # Build armv binary package.
armv -> arm?

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:92: ['-B', '-aarm', '-us', '-uc'],
join(temp_dir, tarroot), toolchain)
Is arm the right architectue here? Shouldn't it be armhf? AFAIK we do use
hard-float. It is a bit difficult to figure this out, but running
'dpkg-architecture -L' shows all known architectures (see
http://www.debian.org/doc/debian-policy/ch-customized-programs.html#s-arch-spec)

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:108: '%s-1_arm.deb' % debbase
armhf here as well?

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
File tools/linux_dist_support/debian/rules (right):

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:21: BUILD_TYPE += ReleaseXARM
ReleaseXARM -> ReleaseARM (no X right?)

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:50: python tools/build.py -v -m release -a
$(ARCH) $(TOOLCHAIN) create_sdk; \
As this is a Makefile all indentation should be TABs.

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:59: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
On 2014/07/30 12:47:06, ricow1 wrote:
> I don't know if we shoujld use tabs like you do above or not,but at least we
> should be consistent

Use TABs in Makefiles.

[zra, 2014-08-14 20:42:53]

PTAL

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
File tools/create_debian_packages.py (right):

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:88: # Build armv binary package.
On 2014/08/05 15:20:29, Søren Gjesse wrote:
> armv -> arm?

Done.

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:92: ['-B', '-aarm', '-us', '-uc'],
join(temp_dir, tarroot), toolchain)
On 2014/08/05 15:20:29, Søren Gjesse wrote:
> Is arm the right architectue here? Shouldn't it be armhf? AFAIK we do use
> hard-float. It is a bit difficult to figure this out, but running
> 'dpkg-architecture -L' shows all known architectures (see
>
http://www.debian.org/doc/debian-policy/ch-customized-programs.html#s-arch-spec)

We currently support both hard and soft fp, which would be armhf and armel in
the debian naming scheme, respectively. The appropriate one to select depends on
the host or cross toolchain being used. I've updated to allow specifying either
armhf or armel, but we probably can't detect which is the right one to use
without dumping and parsing compiler predefined macros. I've setup the 'all'
target here to select armhf, which when run on linux will do a hardfp ARMv7
build.

https://codereview.chromium.org/396123003/diff/20001/tools/create_debian_pack...
tools/create_debian_packages.py:108: '%s-1_arm.deb' % debbase
On 2014/08/05 15:20:29, Søren Gjesse wrote:
> armhf here as well?

Acknowledged.

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
File tools/linux_dist_support/debian/rules (right):

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:21: BUILD_TYPE += ReleaseXARM
On 2014/08/05 15:20:29, Søren Gjesse wrote:
> ReleaseXARM -> ReleaseARM (no X right?)

Changed to detect whether we are doing a cross-build. If not, it uses
ReleaseARM. If so, it uses ReleaseXARM

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:50: python tools/build.py -v -m release -a
$(ARCH) $(TOOLCHAIN) create_sdk; \
On 2014/08/05 15:20:29, Søren Gjesse wrote:
> As this is a Makefile all indentation should be TABs.

Done.

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:59: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
On 2014/08/05 15:20:30, Søren Gjesse wrote:
> On 2014/07/30 12:47:06, ricow1 wrote:
> > I don't know if we shoujld use tabs like you do above or not,but at least we
> > should be consistent
> 
> Use TABs in Makefiles.

Done.

https://codereview.chromium.org/396123003/diff/20001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:59: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
On 2014/07/30 12:47:06, ricow1 wrote:
> I don't know if we shoujld use tabs like you do above or not,but at least we
> should be consistent

Done.

[Søren Gjesse, 2014-08-15 12:06:21]

LGTM!

Thanks for adding this.

https://codereview.chromium.org/396123003/diff/80001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/396123003/diff/80001/tools/build.py#newcode11
tools/build.py:11: import shutil
Accidental change?

https://codereview.chromium.org/396123003/diff/80001/tools/linux_dist_support...
File tools/linux_dist_support/debian/rules (right):

https://codereview.chromium.org/396123003/diff/80001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:63: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
Is this a tab?

[zra, 2014-08-15 15:16:47]

Thanks!

https://codereview.chromium.org/396123003/diff/80001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/396123003/diff/80001/tools/build.py#newcode11
tools/build.py:11: import shutil
On 2014/08/15 12:06:21, Søren Gjesse wrote:
> Accidental change?

shutil is used below in BuildCrossSdk. The script worked from the command line
without this import, but failed when invoked while building the debian package.
Not sure what the reason for the difference is.

https://codereview.chromium.org/396123003/diff/80001/tools/linux_dist_support...
File tools/linux_dist_support/debian/rules (right):

https://codereview.chromium.org/396123003/diff/80001/tools/linux_dist_support...
tools/linux_dist_support/debian/rules:63: dh_shlibdeps
--dpkg-shlibdeps-params=--ignore-missing-info
On 2014/08/15 12:06:21, Søren Gjesse wrote:
> Is this a tab?

Yes. I double-checked. I don't know why it's not showing up right here.

[zra, 2014-08-15 15:20:48]

Committed patchset #6 manually as r39291 (presubmit successful).