Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 396033003: Fix break on unhandled exception (Closed)

Created:
6 years, 5 months ago by hausner
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix break on unhandled exception A recent change broke the exception handler lookup code in the debugger. This fixes issue 19988. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/vm/debugger.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hausner
6 years, 5 months ago (2014-07-15 23:48:07 UTC) #1
srdjan
lgtm
6 years, 5 months ago (2014-07-15 23:54:43 UTC) #2
hausner
Committed patchset #1 manually as r38267 (presubmit successful).
6 years, 5 months ago (2014-07-15 23:55:06 UTC) #3
Florian Schneider
dbc: Please add the repro as a debugger unit test.
6 years, 5 months ago (2014-07-16 11:25:04 UTC) #4
hausner
6 years, 5 months ago (2014-07-16 15:54:53 UTC) #5
Message was sent while issue was closed.
Yes, will do. Tried to get the fix done asap.

Powered by Google App Engine
This is Rietveld 408576698