Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 395623006: Add hierarchy utils and use them in search. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add hierarchy utils and use them in search. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38259

Patch Set 1 #

Total comments: 4

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+665 lines, -183 lines) Patch
M pkg/analysis_server/lib/src/collections.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 4 chunks +93 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +51 lines, -53 lines 0 comments Download
M pkg/analysis_services/lib/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/lib/index/index_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/lib/index/local_file_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/lib/index/local_memory_index.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_services/lib/search/hierarchy.dart View 1 1 chunk +198 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/search/search_engine.dart View 3 chunks +1 line, -78 lines 0 comments Download
A pkg/analysis_services/test/search/hierarchy_test.dart View 1 1 chunk +300 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/search/search_engine_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_services/test/search/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 5 months ago (2014-07-15 06:24:12 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/395623006/diff/1/pkg/analysis_services/lib/search/hierarchy.dart File pkg/analysis_services/lib/search/hierarchy.dart (right): https://codereview.chromium.org/395623006/diff/1/pkg/analysis_services/lib/search/hierarchy.dart#newcode25 pkg/analysis_services/lib/search/hierarchy.dart:25: clazz.accept(new _ElementVisitorAdapter((Element element) { If you used 'visitChildren' ...
6 years, 5 months ago (2014-07-15 19:56:16 UTC) #2
scheglov
https://codereview.chromium.org/395623006/diff/1/pkg/analysis_services/lib/search/hierarchy.dart File pkg/analysis_services/lib/search/hierarchy.dart (right): https://codereview.chromium.org/395623006/diff/1/pkg/analysis_services/lib/search/hierarchy.dart#newcode25 pkg/analysis_services/lib/search/hierarchy.dart:25: clazz.accept(new _ElementVisitorAdapter((Element element) { On 2014/07/15 19:56:16, Brian Wilkerson ...
6 years, 5 months ago (2014-07-15 20:30:12 UTC) #3
scheglov
6 years, 5 months ago (2014-07-15 21:13:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698