Issue 395233002: Move some isolate state setup from C++ code to JumpToExceptionHandler stub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395233002: Move some isolate state setup from C++ code to JumpToExceptionHandler stub (Closed)

Created:
6 years, 5 months ago by Cutch

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move some isolate state setup from C++ code to JumpToExceptionHandler stub (take 3). - CL is the same as take 2, but, I now prohibit the profiler from walking the call stack when the isolate is executing the jump to exception handler. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38300

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -23 lines)			Patch
M	runtime/vm/exceptions.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm64.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment. https://codereview.chromium.org/395233002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/395233002/diff/1/runtime/vm/profiler.cc#newcode1877 runtime/vm/profiler.cc:1877: } Maybe move this bail ...

6 years, 5 months ago (2014-07-16 17:54:09 UTC) #2

Cutch

6 years, 5 months ago (2014-07-16 18:03:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38300 (presubmit successful).

Expand Messages | Collapse Messages