Issue 394923004: As a temporary measure, allow SDK to be specified on analysis server cmd line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394923004: As a temporary measure, allow SDK to be specified on analysis server cmd line. (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov, jwren

CC:
reviews_dartlang.org, pquitslund

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

As a temporary measure, allow SDK to be specified on analysis server cmd line. Once the 'analysis.updateSdks' request is functional, this should be unnecessary. But for now, allow the default SDK to be set via the command line so that we don't block development of editor plugins. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38443

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -31 lines)			Patch
M	pkg/analysis_server/lib/driver.dart	View	4 chunks	+25 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/analysis_server.dart	View	4 chunks	+2 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/lib/src/package_map_provider.dart	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/socket_server.dart	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_server_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/domain_edit_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/domain_server_test.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/package_map_provider_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/search/search_domain_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/socket_server_test.dart	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

This should unblock Phil's snapshot work by allowing him to invoke the snapshot from any ...

6 years, 5 months ago (2014-07-21 21:22:08 UTC) #1

Paul Berry

6 years, 5 months ago (2014-07-21 21:51:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38443 (presubmit successful).

Expand Messages | Collapse Messages