Issue 394543002: Find token at position and query Dart Mind if identifier or keyword.

Issue 394543002: Find token at position and query Dart Mind if identifier or keyword. (Closed)

Created:
6 years, 5 months ago by ahe

Modified:
6 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, kasperl, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Find token at position and query Dart Mind if identifier or keyword. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39134

Patch Set 2 : Address Johnni's comments. #

Patch Set 3 : Merged with r39130. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -13 lines)			Patch
M	dart/site/try/poi/poi.dart	View	1	3 chunks	+166 lines, -10 lines	0 comments	Download
M	dart/tests/try/poi/data/empty_main.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/try/poi/poi_find_test.dart	View		1 chunk	+35 lines, -1 line	0 comments	Download
M	dart/tests/try/poi/poi_test.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/394543002/diff/40001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/394543002/diff/40001/dart/site/try/poi/poi.dart#newcode85 dart/site/try/poi/poi.dart:85: stdin = new StdinIterator(); Double space. https://codereview.chromium.org/394543002/diff/40001/dart/site/try/poi/poi.dart#newcode190 dart/site/try/poi/poi.dart:190: ...

6 years, 5 months ago (2014-07-17 11:25:12 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/394543002/diff/40001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/394543002/diff/40001/dart/site/try/poi/poi.dart#newcode85 dart/site/try/poi/poi.dart:85: stdin = new StdinIterator(); On 2014/07/17 ...

6 years, 4 months ago (2014-08-12 13:21:12 UTC) #3

ahe

6 years, 4 months ago (2014-08-12 13:27:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 39134 (presubmit successful).

Expand Messages | Collapse Messages