Issue 394343003: - Properly setup an Api scope before calling out through the API.

Issue 394343003: - Properly setup an Api scope before calling out through the API. (Closed)

Created:
6 years, 5 months ago by Ivan Posva

Modified:
6 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Properly setup an Api scope before calling out through the API. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38326

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -1 line)			Patch
M	runtime/vm/object.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	tests/language/deferred_in_isolate_app.dart	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
A	tests/language/deferred_in_isolate_lib.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	tests/language/deferred_in_isolate_test.dart	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/394343003/diff/20001/tests/language/deferred_in_isolate_app.dart File tests/language/deferred_in_isolate_app.dart (right): https://codereview.chromium.org/394343003/diff/20001/tests/language/deferred_in_isolate_app.dart#newcode23 tests/language/deferred_in_isolate_app.dart:23: replyPort.send("Error from isolate:\n$error"); something with indentation here. https://codereview.chromium.org/394343003/diff/20001/tests/language/deferred_in_isolate_test.dart ...

6 years, 5 months ago (2014-07-17 12:38:27 UTC) #2

Ivan Posva

Thanks! -Ivan https://codereview.chromium.org/394343003/diff/20001/tests/language/deferred_in_isolate_app.dart File tests/language/deferred_in_isolate_app.dart (right): https://codereview.chromium.org/394343003/diff/20001/tests/language/deferred_in_isolate_app.dart#newcode23 tests/language/deferred_in_isolate_app.dart:23: replyPort.send("Error from isolate:\n$error"); On 2014/07/17 12:38:27, Vyacheslav ...

6 years, 5 months ago (2014-07-17 12:45:13 UTC) #3

Ivan Posva

6 years, 5 months ago (2014-07-17 12:46:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r38326 (presubmit successful).

Expand Messages | Collapse Messages