Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 393323004: Support SameAsFirstInput policy in register allocator when inputs are paired machine registers (Closed)

Created:
6 years, 5 months ago by Cutch
Modified:
6 years, 5 months ago
CC:
regis, reviews_dartlang.org, srdjan, vm-dev_dartlang.org
Visibility:
Public.

Description

Support SameAsFirstInput policy in register allocator when inputs are paired machine registers BUG= R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38290

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M runtime/vm/flow_graph_allocator.cc View 1 2 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
6 years, 5 months ago (2014-07-16 16:07:16 UTC) #1
Vyacheslav Egorov (Google)
LGTM with comment https://codereview.chromium.org/393323004/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/393323004/diff/1/runtime/vm/flow_graph_allocator.cc#newcode1159 runtime/vm/flow_graph_allocator.cc:1159: locs->set_out(0, Location::Pair(in_pair->At(0), in_pair->At(1))); I wonder what ...
6 years, 5 months ago (2014-07-16 16:26:42 UTC) #2
Cutch
https://codereview.chromium.org/393323004/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/393323004/diff/1/runtime/vm/flow_graph_allocator.cc#newcode1159 runtime/vm/flow_graph_allocator.cc:1159: locs->set_out(0, Location::Pair(in_pair->At(0), in_pair->At(1))); On 2014/07/16 16:26:42, Vyacheslav Egorov (Google ...
6 years, 5 months ago (2014-07-16 16:39:29 UTC) #3
Cutch
6 years, 5 months ago (2014-07-16 16:45:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r38290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698