Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 39313003: Fix typos in FileSystemEntity.watch documentation. (Closed)

Created:
7 years, 1 month ago by Mads Ager (chromium)
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix typos in FileSystemEntity.watch documentation. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29157

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M sdk/lib/io/file_system_entity.dart View 1 1 chunk +9 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
7 years, 1 month ago (2013-10-24 06:18:35 UTC) #1
Mads Ager (chromium)
https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart#newcode354 sdk/lib/io/file_system_entity.dart:354: * FSEvents always use recursion internally, so when disabled, ...
7 years, 1 month ago (2013-10-24 06:20:22 UTC) #2
Anders Johnsen
LGTM, thanks... Not my proudest moment ;) https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart#newcode354 sdk/lib/io/file_system_entity.dart:354: * FSEvents ...
7 years, 1 month ago (2013-10-24 06:59:41 UTC) #3
Mads Ager (chromium)
https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/39313003/diff/1/sdk/lib/io/file_system_entity.dart#newcode354 sdk/lib/io/file_system_entity.dart:354: * FSEvents always use recursion internally, so when disabled, ...
7 years, 1 month ago (2013-10-24 07:22:36 UTC) #4
Mads Ager (chromium)
7 years, 1 month ago (2013-10-24 07:23:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698