Issue 393083002: Fix build (link error reproducible on linux with GYP_DEFINES=dart_debug_optimization_level=0).

Issue 393083002: Fix build (link error reproducible on linux with GYP_DEFINES=dart_debug_optimization_level=0). (Closed)

Created:
6 years, 5 months ago by srdjan

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix build (link error reproducible on linux with GYP_DEFINES=dart_debug_optimization_level=0). Committed: https://code.google.com/p/dart/source/detail?r=38251

Patch Set 1 #

Total comments: 4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	2 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #1 manually as r38251 (presubmit successful).

6 years, 5 months ago (2014-07-15 19:49:30 UTC) #2

siva

https://codereview.chromium.org/393083002/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/393083002/diff/1/runtime/vm/object.h#newcode3016 runtime/vm/object.h:3016: sizeof(RawPcDescriptors::PcDescriptorRec); Does this need to be sizeof(....) can it ...

6 years, 5 months ago (2014-07-16 00:41:28 UTC) #3

srdjan

6 years, 5 months ago (2014-07-16 16:17:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/393083002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/393083002/diff/1/runtime/vm/object.h#newcode3016
runtime/vm/object.h:3016: sizeof(RawPcDescriptors::PcDescriptorRec);
On 2014/07/16 00:41:27, siva wrote:
> Does this need to be sizeof(....) can it be
> RawPcDescriptors::kFullSize;
> will that give an error ?

It gives error:
In-class initializer for static data member is not a constant expression

https://codereview.chromium.org/393083002/diff/1/runtime/vm/raw_object.cc
File runtime/vm/raw_object.cc (right):

https://codereview.chromium.org/393083002/diff/1/runtime/vm/raw_object.cc#new...
runtime/vm/raw_object.cc:18: const intptr_t RawPcDescriptors::kFullRecSize =
sizeof(PcDescriptorRec);
On 2014/07/16 00:41:28, siva wrote:
> shouldn't this be (RawPcDescriptors::PcDescriptorRec)

Done, although apparently not needed.

Expand Messages | Collapse Messages