Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 393043005: Modify reflective tests to allow setUp and tearDown to return futures. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Modify reflective tests to allow setUp and tearDown to return futures. This will be needed for analysis server integration tests, so that they can start and stop the server in their setUp and tearDown methods. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M pkg/analysis_testing/lib/reflective_tests.dart View 1 chunk +11 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-15 21:37:45 UTC) #1
scheglov
LGTM
6 years, 5 months ago (2014-07-15 21:40:49 UTC) #2
Paul Berry
6 years, 5 months ago (2014-07-15 21:41:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698