Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392983006: Specifiy MethodMirror.isStatic is terms of whether 'this' is permitted. (Closed)

Created:
6 years, 5 months ago by rmacnak
Modified:
6 years, 5 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Specifiy MethodMirror.isStatic is terms of whether 'this' is permitted. BUG=http://dartbug.com/19059 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=38318

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M sdk/lib/mirrors/mirrors.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/local_function_is_static_test.dart View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M tests/lib/mirrors/method_mirror_properties_test.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmacnak
6 years, 5 months ago (2014-07-16 20:19:05 UTC) #1
gbracha
https://codereview.chromium.org/392983006/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/392983006/diff/1/sdk/lib/mirrors/mirrors.dart#newcode907 sdk/lib/mirrors/mirrors.dart:907: * constructors are static. "A function" rather than a ...
6 years, 5 months ago (2014-07-16 21:01:33 UTC) #2
rmacnak
On 2014/07/16 21:01:33, gbracha wrote: > https://codereview.chromium.org/392983006/diff/1/sdk/lib/mirrors/mirrors.dart > File sdk/lib/mirrors/mirrors.dart (right): > > https://codereview.chromium.org/392983006/diff/1/sdk/lib/mirrors/mirrors.dart#newcode907 > ...
6 years, 5 months ago (2014-07-16 21:45:30 UTC) #3
rmacnak
6 years, 5 months ago (2014-07-16 22:55:17 UTC) #4
gbracha
Spec lgtm
6 years, 5 months ago (2014-07-16 22:59:43 UTC) #5
gbracha
tests lgtm too.
6 years, 5 months ago (2014-07-16 23:08:58 UTC) #6
rmacnak
6 years, 5 months ago (2014-07-16 23:10:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r38318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698