Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392983005: Bump the code_transformers upper bound constraint on analyzer (Closed)

Created:
6 years, 5 months ago by justinfagnani
Modified:
6 years, 5 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bump the code_transformers upper bound constraint on analyzer BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=38266

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/code_transformers/pubspec.yaml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
justinfagnani
I ran tests against analyzer 0.15.7 and 0.21.1
6 years, 5 months ago (2014-07-15 23:11:25 UTC) #1
blois
https://codereview.chromium.org/392983005/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/392983005/diff/1/pkg/code_transformers/pubspec.yaml#newcode7 pkg/code_transformers/pubspec.yaml:7: analyzer: '>=0.21.1 <0.22.0' I thought it works on 0.15.6- ...
6 years, 5 months ago (2014-07-15 23:14:16 UTC) #2
justinfagnani
https://codereview.chromium.org/392983005/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/392983005/diff/1/pkg/code_transformers/pubspec.yaml#newcode7 pkg/code_transformers/pubspec.yaml:7: analyzer: '>=0.21.1 <0.22.0' On 2014/07/15 23:14:16, blois wrote: > ...
6 years, 5 months ago (2014-07-15 23:16:46 UTC) #3
blois
lgtm
6 years, 5 months ago (2014-07-15 23:17:22 UTC) #4
justinfagnani
6 years, 5 months ago (2014-07-15 23:22:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r38266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698