Initial implementation for 'search.findElementReferences'.

Initial implementation for 'search.findElementReferences'.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38201

[Brian Wilkerson, 2014-07-14 17:18:00]

LGTM, but it could use more documentation.

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/socket_server.dart (right):

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/socket_server.dart:14: import
'package:analysis_server/src/search/search_domain.dart';
I kind of like having all of the domains implemented in the same place. Makes it
easier to find them all. But if there's a good reason for search to be different
I guess I'm OK with it.

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/test/sea...
File pkg/analysis_server/test/search/search_domain_test.dart (right):

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/test/sea...
pkg/analysis_server/test/search/search_domain_test.dart:43: //
TODO(brianwilkerson) implement
Will you be implementing these tests later?

[scheglov, 2014-07-14 17:43:47]

I've added some comments.

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/socket_server.dart (right):

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/socket_server.dart:14: import
'package:analysis_server/src/search/search_domain.dart';
On 2014/07/14 17:17:58, Brian Wilkerson wrote:
> I kind of like having all of the domains implemented in the same place. Makes
it
> easier to find them all. But if there's a good reason for search to be
different
> I guess I'm OK with it.

My idea is that given that "search" is an "optional" domain, it should live
separately.
The same applies to the "edit", "refactoring" and "completion" domains.

In theory these could live in a separate packages and mixed together in a driver
composing a server for the client needs.

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/test/sea...
File pkg/analysis_server/test/search/search_domain_test.dart (right):

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/test/sea...
pkg/analysis_server/test/search/search_domain_test.dart:43: //
TODO(brianwilkerson) implement
On 2014/07/14 17:17:58, Brian Wilkerson wrote:
> Will you be implementing these tests later?

Not here, and not in this way, but yes.
I keep them here for now as a reminder that these commands are not implemented
and not tested yet.

[scheglov, 2014-07-14 17:45:38]

Committed patchset #2 manually as r38201 (presubmit successful).

[Brian Wilkerson, 2014-07-14 17:49:56]

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/socket_server.dart (right):

https://codereview.chromium.org/392693002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/socket_server.dart:14: import
'package:analysis_server/src/search/search_domain.dart';
> My idea is that given that "search" is an "optional" domain, it should live
> separately.

Technically, *all* domains are optional. Until we actually move them into
separate packages I don't see any reason to change the structure. Just my
opinion.