Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 392563003: Fix class implementing FormatException getting warnings. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Fix class implementing FormatException getting warnings. Update mirrors-used-test count. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=38182

Patch Set 1 #

Total comments: 10

Patch Set 2 : merge-to-head #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/source_maps/lib/span.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 chunk +1 line, -1 line 1 comment Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lasse Reichstein Nielsen
https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/pubspec.yaml File pkg/source_maps/pubspec.yaml (right): https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/pubspec.yaml#newcode4 pkg/source_maps/pubspec.yaml:4: # lib/src/barback.dart. Pub implicitly places a version constraint on ...
6 years, 5 months ago (2014-07-14 09:14:49 UTC) #1
kustermann
lgtm
6 years, 5 months ago (2014-07-14 09:17:29 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #2 manually as r38182 (presubmit successful).
6 years, 5 months ago (2014-07-14 09:24:28 UTC) #3
nweiz
https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart#newcode391 pkg/source_maps/lib/span.dart:391: get source => null; This should be "span == ...
6 years, 5 months ago (2014-07-14 19:24:16 UTC) #4
nweiz
https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart#newcode391 pkg/source_maps/lib/span.dart:391: get source => null; On 2014/07/14 19:24:15, nweiz wrote: ...
6 years, 5 months ago (2014-07-14 19:35:51 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/392563003/diff/1/pkg/source_maps/lib/span.dart#newcode391 pkg/source_maps/lib/span.dart:391: get source => null; Done. I have added the ...
6 years, 5 months ago (2014-07-15 09:19:49 UTC) #6
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-07-16 00:49:24 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/392563003/diff/20001/pkg/source_maps/pubspec....
File pkg/source_maps/pubspec.yaml (right):

https://codereview.chromium.org/392563003/diff/20001/pkg/source_maps/pubspec....
pkg/source_maps/pubspec.yaml:10: version: 0.9.2+4-dev
FYI - note that this version is incorrect because '-' takes precedence over '+'.
That is, 0.9.2+4-dev is interpreted more like 0.9.2-dev+4, which is considered
an older version than 0.9.2+3. When we want to switch to a dev version and we
have a +, we bump the patch too (0.9.3-dev in this case).

There are a couple changes in flight that will change this to something else, so
I don't think we need to fix this separately.

Powered by Google App Engine
This is Rietveld 408576698