Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 391943003: Allow for no embedder provided library tag handler (Closed)

Created:
6 years, 5 months ago by Cutch
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Leaf
Visibility:
Public.

Description

Dartium doesn't have a library tag handler installed in the service isolate. Allow for no embedder provided library tag handler so long as no imports need to be handled. Fixes part of https://code.google.com/p/dart/issues/detail?id=20049 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38239

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M runtime/vm/service.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
6 years, 5 months ago (2014-07-15 14:52:44 UTC) #1
siva
LGTM with one comment. https://codereview.chromium.org/391943003/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/391943003/diff/1/runtime/vm/service.cc#newcode572 runtime/vm/service.cc:572: ASSERT(embedder_provided_handler_ != NULL); instead of ...
6 years, 5 months ago (2014-07-15 16:06:54 UTC) #2
Cutch
https://codereview.chromium.org/391943003/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/391943003/diff/1/runtime/vm/service.cc#newcode572 runtime/vm/service.cc:572: ASSERT(embedder_provided_handler_ != NULL); On 2014/07/15 16:06:54, siva wrote: > ...
6 years, 5 months ago (2014-07-15 16:33:51 UTC) #3
Cutch
6 years, 5 months ago (2014-07-15 16:34:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698