Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 391003005: Update test expectation for Safari to account for JSON.parse bug. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
Reviewers:
ahe, Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update test expectation for Safari to account for JSON.parse bug. Also use num.parse now that we have it. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=38223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tests/lib/convert/json_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-15 07:28:40 UTC) #1
ahe
lgtm
6 years, 5 months ago (2014-07-15 07:32:19 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r38223 (presubmit successful).
6 years, 5 months ago (2014-07-15 08:01:52 UTC) #3
Bill Hesse
6 years, 5 months ago (2014-07-15 11:12:56 UTC) #4
Message was sent while issue was closed.
The failing test is called convert/json_test, not convert/json_parse_test.

Powered by Google App Engine
This is Rietveld 408576698