Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 390043002: Fix dartbug.com/19998 (Closed)

Created:
6 years, 5 months ago by Ivan Posva
Modified:
6 years, 5 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix dartbug.com/19998 - Do not attempt to interact with files if hooks are not installed. - Remove obsolete code observers. - Remove obsolete API functions. R=asiva@google.com, fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=38226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -261 lines) Patch
M runtime/include/dart_native_api.h View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/vm/native_api_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/os_android.cc View 5 chunks +7 lines, -69 lines 0 comments Download
M runtime/vm/os_linux.cc View 5 chunks +6 lines, -163 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
6 years, 5 months ago (2014-07-14 14:25:21 UTC) #1
Florian Schneider
LGTM.
6 years, 5 months ago (2014-07-14 14:30:06 UTC) #2
siva
lgtm
6 years, 5 months ago (2014-07-14 17:27:01 UTC) #3
Ivan Posva
6 years, 5 months ago (2014-07-15 09:14:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698