Issue 390003004: Use relative paths to the packages from 'pkg' folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390003004: Use relative paths to the packages from 'pkg' folder. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
nweiz, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use relative paths to the packages from 'pkg' folder. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38217

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/analysis_services/pubspec.yaml	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	pkg/analysis_testing/pubspec.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r38217 (presubmit successful).

6 years, 5 months ago (2014-07-14 22:08:25 UTC) #3

nweiz

6 years, 5 months ago (2014-07-17 18:13:41 UTC) #4

Message was sent while issue was closed.

Don't commit path dependencies for packages in the repo. You shouldn't ever need
them anyway; the build process creates a package root (in <build dir>/packages)
that has symlinks to all the repo packages, and you should be using that
everywhere. Path dependencies also can't be uploaded and don't include version
constraints, so there's now no documentation in the repository for what
dependency versions these packages support.

This is breaking the pub bots, so please revert it ASAP. In the future, when
making changes to the versions or version constraints in your packages, please
include rnystrom and/or myself on the CL.

Expand Messages | Collapse Messages