Issue 38993004: Update test expectations to also cover analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 38993004: Update test expectations to also cover analyzer. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 1 month ago

Reviewers:
floitsch, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test expectations to also cover analyzer. CO19 tests still use Match.str. Committed: https://code.google.com/p/dart/source/detail?r=29172

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tests/co19/co19-co19.status	View		2 chunks	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r29172 (presubmit successful).

7 years, 2 months ago (2013-10-24 12:38:11 UTC) #1

kustermann

7 years, 1 month ago (2013-10-25 10:44:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/38993004/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/38993004/diff/1/tests/co19/co19-co19.status#n...
tests/co19/co19-co19.status:11: [ $runtime == vm || $runtime != vm ]
This is not necessary, it's the first section in the status file (i.e. without
the header it will affect everything)!

Expand Messages | Collapse Messages