Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 389573007: Remove MirroredCompilationError from the VM. (Closed)

Created:
6 years, 5 months ago by rmacnak
Modified:
6 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha
Visibility:
Public.

Description

Remove MirroredCompilationError from the VM. Regenerate snapshot test due to removed symbol. BUG=http://dartbug.com/16562 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=38202

Patch Set 1 #

Patch Set 2 : rebase + regen snapshot test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -175 lines) Patch
M runtime/lib/mirrors.cc View 23 chunks +22 lines, -48 lines 0 comments Download
M runtime/lib/mirrors_patch.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D runtime/tests/vm/dart/mirrored_compilation_error_test.dart View 1 chunk +0 lines, -103 lines 0 comments Download
M runtime/tests/vm/vm.status View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/mirrors/removed_api_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/issue14236_test.dart View 1 Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
6 years, 5 months ago (2014-07-14 17:32:50 UTC) #1
regis
LGTM
6 years, 5 months ago (2014-07-14 17:54:45 UTC) #2
rmacnak
6 years, 5 months ago (2014-07-14 18:00:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698