Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 389413002: Use HasToJson when set Reponse/Notification parameters. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use HasToJson when set Reponse/Notification parameters. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -21 lines) Patch
A pkg/analysis_server/lib/src/collections.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 4 chunks +17 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_result.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-14 19:27:13 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-14 19:52:27 UTC) #2
scheglov
6 years, 5 months ago (2014-07-14 19:54:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38206 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698