Issue 388813002: Serialize scope information at point-of-interest.

Issue 388813002: Serialize scope information at point-of-interest. (Closed)

Created:
6 years, 5 months ago by ahe

Modified:
6 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, lukechurch, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Serialize scope information at point-of-interest. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38188

Patch Set 2 : Merged with r38151. #

Patch Set 3 : Skip serialization test in browsers #

Total comments: 4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -29 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/site/try/poi/poi.dart	View		6 chunks	+139 lines, -28 lines	4 comments	Download
A +	dart/tests/try/poi/data/interesting.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	dart/tests/try/poi/poi_find_test.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download
A	dart/tests/try/poi/serialize_test.dart	View		1 chunk	+86 lines, -0 lines	0 comments	Download
M	dart/tests/try/try.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.dart#newcode110 dart/site/try/poi/poi.dart:110: ScopeInformationVisitor vistor = 'vistor' -> 'visitor'. https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.dart#newcode161 dart/site/try/poi/poi.dart:161: ...

6 years, 5 months ago (2014-07-14 10:35:36 UTC) #2

ahe

Committed patchset #3 manually as r38188 (presubmit successful).

6 years, 5 months ago (2014-07-14 13:02:32 UTC) #3

ahe

6 years, 5 months ago (2014-07-14 13:06:07 UTC) #4

Message was sent while issue was closed.

Forgot to upload patch set before committing.

https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.dart
File dart/site/try/poi/poi.dart (right):

https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.da...
dart/site/try/poi/poi.dart:110: ScopeInformationVisitor vistor =
On 2014/07/14 10:35:36, Johnni Winther wrote:
> 'vistor' -> 'visitor'.

Done.

https://codereview.chromium.org/388813002/diff/50001/dart/site/try/poi/poi.da...
dart/site/try/poi/poi.dart:161: // TODO(ahe): Include function paramters and
local variables.
On 2014/07/14 10:35:36, Johnni Winther wrote:
> 'paramters' -> 'parameters'

Done.

Expand Messages | Collapse Messages