Issue 388753002: Remove suppression for language/dynamic_prefix_core_test/01

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 388753002: Remove suppression for language/dynamic_prefix_core_test/01 (Closed)

Created:
6 years, 5 months ago by ricow1

Modified:
6 years, 5 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove suppression for language/dynamic_prefix_core_test/01 It is not failing on the bots. Suppression was introduced in r38113 - Sigurd: maybe you missed adding a file to the changeset in that revision? Committed: https://code.google.com/p/dart/source/detail?r=38146

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r38146 (presubmit successful).

6 years, 5 months ago (2014-07-11 05:26:19 UTC) #3

sigurdm

6 years, 5 months ago (2014-07-11 07:13:41 UTC) #4

Message was sent while issue was closed.

lgtm

My change was like this

-[ ($compiler == none || $compiler == dart2dart) && $runtime != none ]
-dynamic_prefix_core_test/01: Fail # Issue 12478
+[ $compiler == none && $runtime != none ]
+dynamic_prefix_core_test/01: RuntimeError # Issue 12478
+
+[ $compiler == dart2dart && $runtime != none && $builder_tag != new_backend ]
+dynamic_prefix_core_test/01: RuntimeError # Issue 12478

I think I got confused by the many different conditions - and I forgot to run
the test with the old dart2dart backend.

Thanks for helping me out.

Expand Messages | Collapse Messages