Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 387993007: 5% smaller snapshots by omitting object ids when possible (Closed)

Created:
6 years, 5 months ago by koda
Modified:
6 years, 5 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Object ids in snapshots are assigned sequentially, and can in many cases be omitted by the writer and inferred by the reader. The exceptions are the classes that are serialized in two steps (arrays and user-level Dart instances), where the second step must include the id. For standalone, makes full snapshot 5% smaller, and startup ~1.5% faster when measured on a Nexus 10. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38261

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -14 lines) Patch
M runtime/vm/dart_api_message.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 2 3 4 4 chunks +16 lines, -3 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 11 chunks +38 lines, -11 lines 0 comments Download
M runtime/vm/snapshot_ids.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M tests/standalone/issue14236_test.dart View 1 2 Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 5 months ago (2014-07-15 01:34:18 UTC) #1
zra
lgtm https://codereview.chromium.org/387993007/diff/80001/runtime/vm/snapshot_ids.h File runtime/vm/snapshot_ids.h (right): https://codereview.chromium.org/387993007/diff/80001/runtime/vm/snapshot_ids.h#newcode23 runtime/vm/snapshot_ids.h:23: kOmittedObjectId, Would it make sense to hardcode this ...
6 years, 5 months ago (2014-07-15 16:50:30 UTC) #2
koda
On 2014/07/15 16:50:30, zra wrote: > lgtm > > https://codereview.chromium.org/387993007/diff/80001/runtime/vm/snapshot_ids.h > File runtime/vm/snapshot_ids.h (right): > ...
6 years, 5 months ago (2014-07-15 21:29:12 UTC) #3
koda
6 years, 5 months ago (2014-07-15 21:47:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r38261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698