Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 386563002: Add "point of interest" app for command-line testing of dart2js type information. (Closed)

Created:
6 years, 5 months ago by ahe
Modified:
6 years, 5 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Visibility:
Public.

Description

Add "point of interest" app for command-line testing of dart2js type information. For now, the app only prints the location of an offset given at command line. Example usage: dart -p$BUILD_DIRECTORY/ReleaseIA32/packages/ poi.dart DART_FILE OFFSET R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=38114

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -535 lines) Patch
A dart/site/try/poi/poi.dart View 1 1 chunk +63 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/memory_compiler.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D dart/tests/try/cursor_position_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D dart/tests/try/end_to_end_test.dart View 1 chunk +0 lines, -112 lines 0 comments Download
D dart/tests/try/internal_error_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D dart/tests/try/mock_try.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D dart/tests/try/paste_content_rewriting_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
A + dart/tests/try/poi/poi_test.dart View 1 1 chunk +9 lines, -11 lines 0 comments Download
D dart/tests/try/source_update_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D dart/tests/try/test_case.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D dart/tests/try/test_try.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M dart/tests/try/try.status View 1 chunk +7 lines, -4 lines 0 comments Download
A + dart/tests/try/web/cursor_position_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/try/web/end_to_end_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/try/web/internal_error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + dart/tests/try/web/mock_try.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/try/web/paste_content_rewriting_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + dart/tests/try/web/source_update_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/try/web/test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
A + dart/tests/try/web/test_try.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tools/bots/compiler.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
Adding a new app that does virtually nothing. But it is enough to set up ...
6 years, 5 months ago (2014-07-10 08:36:07 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/386563002/diff/40001/dart/tests/try/poi/poi_test.dart File dart/tests/try/poi/poi_test.dart (right): https://codereview.chromium.org/386563002/diff/40001/dart/tests/try/poi/poi_test.dart#newcode13 dart/tests/try/poi/poi_test.dart:13: poi.main(<String>[Platform.script.toFilePath(), '339']); Is there any way you could ...
6 years, 5 months ago (2014-07-10 09:27:07 UTC) #2
ahe
https://codereview.chromium.org/386563002/diff/40001/dart/tests/try/poi/poi_test.dart File dart/tests/try/poi/poi_test.dart (right): https://codereview.chromium.org/386563002/diff/40001/dart/tests/try/poi/poi_test.dart#newcode13 dart/tests/try/poi/poi_test.dart:13: poi.main(<String>[Platform.script.toFilePath(), '339']); On 2014/07/10 09:27:07, kasperl wrote: > Is ...
6 years, 5 months ago (2014-07-10 10:35:23 UTC) #3
ahe
6 years, 5 months ago (2014-07-10 10:38:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698