Throw CyclicInitializationError instead of string

Throw CyclicInitializationError instead of string

For some reason, I had to regenerate the snapshot for test standalone/issue14236_source.dart. The checked-in snapshot crashed with my change. We don't know yet why. Siva is looking at this separately.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29397

[srdjan, 2013-10-28 21:32:02]

LGTM with comments

https://codereview.chromium.org/38563005/diff/50001/runtime/lib/errors_patch....
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/38563005/diff/50001/runtime/lib/errors_patch....
runtime/lib/errors_patch.dart:113: patch class CyclicInitializationError {
extends Error (so that it collects full stacktrace).

https://codereview.chromium.org/38563005/diff/50001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/38563005/diff/50001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:971: // call
CyclicInitializationError._throwNew(field_name).
s/call/Call/

[hausner, 2013-10-28 21:35:38]

Thank you.

https://codereview.chromium.org/38563005/diff/50001/runtime/lib/errors_patch....
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/38563005/diff/50001/runtime/lib/errors_patch....
runtime/lib/errors_patch.dart:113: patch class CyclicInitializationError {
On 2013/10/28 21:32:02, srdjan wrote:
> extends Error (so that it collects full stacktrace).

The original class declares the super class. This is just a patch class.

https://codereview.chromium.org/38563005/diff/50001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/38563005/diff/50001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:971: // call
CyclicInitializationError._throwNew(field_name).
On 2013/10/28 21:32:02, srdjan wrote:
> s/call/Call/

Done.

[hausner, 2013-10-28 21:39:13]

Committed patchset #3 manually as r29397 (presubmit successful).