Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 385163002: Make VM JSON parser parse doubles without doing substring. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make VM JSON parser parse doubles without doing substring. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=38155

Patch Set 1 #

Patch Set 2 : Fix bad whitespace edit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M runtime/lib/convert_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/convert/json_test.dart View 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-11 11:21:45 UTC) #1
Lasse Reichstein Nielsen
This was part of CL 368483004, but somehow failed to be committed.
6 years, 5 months ago (2014-07-11 11:36:15 UTC) #2
Florian Schneider
lgtm
6 years, 5 months ago (2014-07-11 11:51:10 UTC) #3
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-11 12:14:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698