Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 384393002: Fix analyzer status after my previous CL. (Closed)

Created:
6 years, 5 months ago by Florian Schneider
Modified:
6 years, 5 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analyzer status after my previous CL. The test I added is expected to produce warnings because it tests invalid noSuchMethod overriding. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
tbr
6 years, 5 months ago (2014-07-14 11:16:02 UTC) #1
Florian Schneider
Committed patchset #1 manually as r38186 (presubmit successful).
6 years, 5 months ago (2014-07-14 11:16:21 UTC) #2
Ivan Posva
6 years, 5 months ago (2014-07-14 11:45:08 UTC) #3
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698