Add .wasParsed() to ArgResults.

Add .wasParsed() to ArgResults.

BUG=https://code.google.com/p/dart/issues/detail?id=16227
R=alanknight@google.com, nweiz@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38348

[nweiz, 2014-07-14 21:22:34]

lgtm

https://codereview.chromium.org/383913003/diff/1/pkg/args/CHANGELOG.md
File pkg/args/CHANGELOG.md (right):

https://codereview.chromium.org/383913003/diff/1/pkg/args/CHANGELOG.md#newcode6
pkg/args/CHANGELOG.md:6: * Replaced `isFlag` and `allowMultiple` fields in
`Option` with a three-value
"in `Option`" -> "in the `Option` class". This will help make it clear that most
users don't have to care about this change.

The change in arguments to [new ArgParser] is also technically a breaking change
and should be documented here. Alternately, mark the ArgParser and Option
constructors as internal so that these changes aren't breaking in the future.

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dart
File pkg/args/lib/src/options.dart (right):

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dar...
pkg/args/lib/src/options.dart:105: const OptionType(this.name);
This should be private.

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dar...
pkg/args/lib/src/options.dart:107: final String name;
Nit: fields go above constructors.

[Bob Nystrom, 2014-07-15 21:05:24]

I moved some code around and also widened constraints for the other packages
that depend on args since they work fine with the new 0.12.0 version. PTAL!

https://codereview.chromium.org/383913003/diff/1/pkg/args/CHANGELOG.md
File pkg/args/CHANGELOG.md (right):

https://codereview.chromium.org/383913003/diff/1/pkg/args/CHANGELOG.md#newcode6
pkg/args/CHANGELOG.md:6: * Replaced `isFlag` and `allowMultiple` fields in
`Option` with a three-value
On 2014/07/14 21:22:34, nweiz wrote:
> "in `Option`" -> "in the `Option` class". This will help make it clear that
most
> users don't have to care about this change.

Done.

> The change in arguments to [new ArgParser] is also technically a breaking
change
> and should be documented here. Alternately, mark the ArgParser and Option
> constructors as internal so that these changes aren't breaking in the future.

Done and then some. Made them private and reorganized the internal libraries.

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dart
File pkg/args/lib/src/options.dart (right):

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dar...
pkg/args/lib/src/options.dart:105: const OptionType(this.name);
On 2014/07/14 21:22:34, nweiz wrote:
> This should be private.

Done.

https://codereview.chromium.org/383913003/diff/1/pkg/args/lib/src/options.dar...
pkg/args/lib/src/options.dart:107: final String name;
On 2014/07/14 21:22:34, nweiz wrote:
> Nit: fields go above constructors.

Done.

[nweiz, 2014-07-15 21:24:10]

lgtm, although you should probably loop in the authors of the packages whose
pubspecs this changes.

[Bob Nystrom, 2014-07-15 22:20:29]

Newly added folks, I tweaked the version constraint on args in your packages.
The change to args here is backwards compatible for you. PTAL, thanks!

[Alan Knight, 2014-07-15 22:21:34]

lgtm

[Siggi Cherem (dart-lang), 2014-07-15 22:26:03]

lgtm

[Bob Nystrom, 2014-07-17 21:35:53]

Committed patchset #4 manually as r38348 (presubmit successful).