Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 383903005: Reapply "Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM… (Closed)

Created:
6 years, 5 months ago by rmacnak
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reapply "Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM's mirrors." Reapply "Use mirror-free LRU test for dart2js" BUG=http://dartbug.com/18445 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -26 lines) Patch
M runtime/lib/mirrors_impl.dart View 5 chunks +6 lines, -24 lines 0 comments Download
M sdk/lib/internal/internal.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/internal/internal_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/internal/lru.dart View 1 chunk +125 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js_native/lru_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/lru_expect.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib/mirrors/lru_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
6 years, 5 months ago (2014-07-11 17:36:29 UTC) #1
siva
lgtm
6 years, 5 months ago (2014-07-11 18:13:36 UTC) #2
rmacnak
6 years, 5 months ago (2014-07-11 18:59:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698