Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 383823002: Adding support for `sourceRoot` to the SingleMapping class. (Closed)

Created:
6 years, 5 months ago by tjblasi
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding support for `sourceRoot` to the SingleMapping class. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38241

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use string interpolation for concat rather than '+'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M pkg/source_maps/lib/parser.dart View 1 7 chunks +22 lines, -9 lines 0 comments Download
M pkg/source_maps/test/parser_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tjblasi
Clearing out a TODO in source_maps. Thanks for looking!
6 years, 5 months ago (2014-07-14 22:31:41 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart#newcode359 pkg/source_maps/lib/parser.dart:359: url = sourceRoot + url; is source root guaranteed ...
6 years, 5 months ago (2014-07-14 22:46:53 UTC) #2
tjblasi
https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart#newcode359 pkg/source_maps/lib/parser.dart:359: url = sourceRoot + url; I wasn't sure how ...
6 years, 5 months ago (2014-07-15 00:13:59 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart#newcode359 pkg/source_maps/lib/parser.dart:359: url = sourceRoot + url; On 2014/07/15 00:13:58, ...
6 years, 5 months ago (2014-07-15 00:29:38 UTC) #4
tjblasi
Thanks again! https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/383823002/diff/1/pkg/source_maps/lib/parser.dart#newcode359 pkg/source_maps/lib/parser.dart:359: url = sourceRoot + url; On 2014/07/15 ...
6 years, 5 months ago (2014-07-15 16:45:10 UTC) #5
Siggi Cherem (dart-lang)
lgtm, thanks Tim!
6 years, 5 months ago (2014-07-15 16:47:33 UTC) #6
tjblasi
6 years, 5 months ago (2014-07-15 16:48:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r38241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698