Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383523005: Specify descriptor kind to iterate on. (Closed)

Created:
6 years, 5 months ago by srdjan
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Specify descriptor kind to iterate on. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38128

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -91 lines) Patch
M runtime/vm/code_descriptors_test.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M runtime/vm/coverage.cc View 1 2 3 4 5 1 chunk +25 lines, -29 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 7 chunks +16 lines, -19 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 1 chunk +30 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 10 chunks +12 lines, -15 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 2 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
Very similar to the CL you already reviewed with all the comments applied. Removed code ...
6 years, 5 months ago (2014-07-10 18:09:36 UTC) #1
siva
lgtm https://codereview.chromium.org/383523005/diff/80001/runtime/vm/coverage.cc File runtime/vm/coverage.cc (right): https://codereview.chromium.org/383523005/diff/80001/runtime/vm/coverage.cc#newcode100 runtime/vm/coverage.cc:100: const ICData* ic_data= (*ic_data_array)[deopt_id]; ic_data = https://codereview.chromium.org/383523005/diff/80001/runtime/vm/raw_object.h File ...
6 years, 5 months ago (2014-07-10 18:21:21 UTC) #2
srdjan
https://codereview.chromium.org/383523005/diff/80001/runtime/vm/coverage.cc File runtime/vm/coverage.cc (right): https://codereview.chromium.org/383523005/diff/80001/runtime/vm/coverage.cc#newcode100 runtime/vm/coverage.cc:100: const ICData* ic_data= (*ic_data_array)[deopt_id]; On 2014/07/10 18:21:21, siva wrote: ...
6 years, 5 months ago (2014-07-10 18:24:48 UTC) #3
srdjan
6 years, 5 months ago (2014-07-10 19:44:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #6 manually as r38128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698