Issue 38343004: - Don't mix the collection of Error.stackTrace with the collection of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 38343004: - Don't mix the collection of Error.stackTrace with the collection of (Closed)

Created:
7 years, 2 months ago by Ivan Posva

Modified:
7 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Don't mix the collection of Error.stackTrace with the collection of the stack trace for try-catch. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29136

Patch Set 2 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -18 lines)			Patch
	A	runtime/tests/vm/dart/error_stacktrace_test.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
	M	runtime/vm/exceptions.cc	View		2 chunks	+28 lines, -18 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/38343004/diff/20001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/38343004/diff/20001/runtime/vm/exceptions.cc#newcode415 runtime/vm/exceptions.cc:415: // Create arrays for fcode and pc_offset tuples ...

7 years, 2 months ago (2013-10-24 00:16:10 UTC) #2

Ivan Posva

https://codereview.chromium.org/38343004/diff/20001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/38343004/diff/20001/runtime/vm/exceptions.cc#newcode415 runtime/vm/exceptions.cc:415: // Create arrays for fcode and pc_offset tuples of ...

7 years, 2 months ago (2013-10-24 00:16:41 UTC) #3

Ivan Posva

7 years, 2 months ago (2013-10-24 00:17:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29136 (presubmit successful).

Expand Messages | Collapse Messages

Issue 38343004: - Don't mix the collection of Error.stackTrace with the collection of (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages