Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383413003: Add @Native(...) annotation for native class names. (Closed)

Created:
6 years, 5 months ago by Johnni Winther
Modified:
6 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Add @Native(...) annotation for native class names. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38375

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -275 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 1 3 chunks +139 lines, -37 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/annotations.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 4 chunks +9 lines, -63 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_native/abstract_class_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/bound_closure_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_prepatched_test.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_1_unpatched_test.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/browser_compat_2_test.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/call_on_native_class_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/core_type_check_native_test.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/downcast_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/field_type2_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/field_type_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/fixup_get_tag_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/hash_code_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/is_check_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/issue9182_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/jsobject_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/mirror_intercepted_field_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity2_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_arguments1_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_fields_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_avoids_hidden_name_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_2_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_3_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance1_frog_test.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance2_frog_test.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance3_frog_test.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check1_frog_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check3_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_closure_identity_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_constructor_name_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_equals_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_exception2_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_exception_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_exceptions1_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation2_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation3_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation4_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation5_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation6_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_name_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_1_frog_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_lib2.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_inlining_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_with_keyword_name_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mirror_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_missing_method1_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_missing_method2_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_mixin_field_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple2_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple3_test.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_with_plain_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception2_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception5_frog_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception_frog_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_novel_html_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_null_closure_frog_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_null_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_to_string_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_use_native_name_in_table_frog_test.dart View 3 chunks +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_window1_frog_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_window2_frog_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function3_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function_frog_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/oddly_named_fields_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/rti_only_native_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/runtimetype_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_1_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_2_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_3_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_4_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_5_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_1_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_2_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_call_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_1_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_super_field_2_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_type_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/super_call_test.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/super_property_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/uninstantiated_type_parameter_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
6 years, 5 months ago (2014-07-13 12:45:35 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/383413003/diff/1/sdk/lib/_internal/compiler/implementation/patch_parser.dart File sdk/lib/_internal/compiler/implementation/patch_parser.dart (right): https://codereview.chromium.org/383413003/diff/1/sdk/lib/_internal/compiler/implementation/patch_parser.dart#newcode348 sdk/lib/_internal/compiler/implementation/patch_parser.dart:348: Token argument = annotation.beginToken.next.next.next; Comment what tokens are ...
6 years, 5 months ago (2014-07-14 19:33:00 UTC) #2
Johnni Winther
Committed patchset #2 manually as r38375 (presubmit successful).
6 years, 5 months ago (2014-07-18 08:53:37 UTC) #3
Johnni Winther
6 years, 5 months ago (2014-07-18 08:59:32 UTC) #4
Message was sent while issue was closed. 
https://codereview.chromium.org/383413003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/patch_parser.dart (right):

https://codereview.chromium.org/383413003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/patch_parser.dart:348: Token argument
= annotation.beginToken.next.next.next;
On 2014/07/14 19:32:59, floitsch wrote:
> Comment what tokens are skipped.

Done.

https://codereview.chromium.org/383413003/diff/1/tests/compiler/dart2js/dart_...
File tests/compiler/dart2js/dart_backend_test.dart (right):

https://codereview.chromium.org/383413003/diff/1/tests/compiler/dart2js/dart_...
tests/compiler/dart2js/dart_backend_test.dart:17: 'Math': '''class Math {
On 2014/07/14 19:32:59, floitsch wrote:
> this should be double.parse.
> 
> We don't have a class Math.
> 
> (probably doesn't really matter...

Changed.

https://codereview.chromium.org/383413003/diff/1/tests/compiler/dart2js/dart_...
tests/compiler/dart2js/dart_backend_test.dart:546: var x =
Math.parseDouble("1");
On 2014/07/14 19:32:59, floitsch wrote:
> change to double.parse("1"); ?

Done.

Powered by Google App Engine
This is Rietveld 408576698