Issue 38333004: Fixes all canonicalization problems... all of them. Ok, not all of them, but at

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 38333004: Fixes all canonicalization problems... all of them. Ok, not all of them, but at (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes all canonicalization problems... all of them. Ok, not all of them, but at least it should address the many issues people have been hitting. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29137

Patch Set 1 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -36 lines)			Patch
M	pkg/pkg.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View	3 chunks	+7 lines, -0 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/a.dart	View	1 chunk	+9 lines, -5 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/a.html	View	1 chunk	+3 lines, -8 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/b.dart	View	1 chunk	+9 lines, -5 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/b.html	View	1 chunk	+3 lines, -8 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/c.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A +	pkg/polymer/example/canonicalization/lib/d.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	pkg/polymer/example/canonicalization/pubspec.yaml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	pkg/polymer/example/canonicalization/test/canonicalization_deploy_test.dart	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	pkg/polymer/example/canonicalization/test/canonicalization_deploy_test.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	pkg/polymer/example/canonicalization/test/canonicalization_test.dart	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	pkg/polymer/example/canonicalization/test/canonicalization_test.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/deploy.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/polymer/lib/src/build/runner.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/polymer/lib/src/loader.dart	View	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

7 years, 2 months ago (2013-10-24 00:35:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29137 (presubmit successful).

Expand Messages | Collapse Messages