Issue 383063005: Refactor snapshot writer's forward list into a reusable class.

Issue 383063005: Refactor snapshot writer's forward list into a reusable class. (Closed)

Created:
6 years, 5 months ago by koda

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Refactor snapshot writer's forward list into a reusable class. Also add an optimization to avoid potential quadratic behavior. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38172

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -43 lines)			Patch
M	runtime/vm/raw_object.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1 2	4 chunks	+60 lines, -22 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2	10 chunks	+50 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/383063005/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/383063005/diff/20001/runtime/vm/snapshot.h#newcode493 runtime/vm/snapshot.h:493: : first_object_id_(first_object_id), normally we initialize all the fields ...

6 years, 5 months ago (2014-07-11 19:57:49 UTC) #2

koda

https://codereview.chromium.org/383063005/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/383063005/diff/20001/runtime/vm/snapshot.h#newcode493 runtime/vm/snapshot.h:493: : first_object_id_(first_object_id), On 2014/07/11 19:57:48, siva wrote: > normally ...

6 years, 5 months ago (2014-07-11 21:06:40 UTC) #3

koda

6 years, 5 months ago (2014-07-11 21:07:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r38172 (presubmit successful).

Expand Messages | Collapse Messages