Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382993003: More PcDescriptor cleanups. (Closed)

Created:
6 years, 5 months ago by srdjan
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

More PcDescriptor cleanups, compress recors if no try index is needed (frequent). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38242

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -95 lines) Patch
M runtime/vm/code_descriptors.h View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/coverage.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 5 10 chunks +16 lines, -16 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 3 chunks +21 lines, -14 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 12 chunks +45 lines, -25 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 3 4 5 2 chunks +62 lines, -12 lines 0 comments Download
M runtime/vm/parser.h View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 1 chunk +45 lines, -7 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 2 3 4 5 2 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
6 years, 5 months ago (2014-07-11 23:40:00 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/382993003/diff/60001/runtime/vm/code_descriptors.h File runtime/vm/code_descriptors.h (right): https://chromiumcodereview.appspot.com/382993003/diff/60001/runtime/vm/code_descriptors.h#newcode57 runtime/vm/code_descriptors.h:57: return list_[index].try_index; Should this be: return (!has_try_index_) ? ...
6 years, 5 months ago (2014-07-14 19:42:01 UTC) #2
srdjan
https://chromiumcodereview.appspot.com/382993003/diff/60001/runtime/vm/code_descriptors.h File runtime/vm/code_descriptors.h (right): https://chromiumcodereview.appspot.com/382993003/diff/60001/runtime/vm/code_descriptors.h#newcode57 runtime/vm/code_descriptors.h:57: return list_[index].try_index; On 2014/07/14 19:42:01, siva wrote: > Should ...
6 years, 5 months ago (2014-07-14 23:55:26 UTC) #3
srdjan
6 years, 5 months ago (2014-07-15 17:07:14 UTC) #4
Message was sent while issue was closed. 
Committed patchset #6 manually as r38242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698