Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 382993002: SearchEngine service. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

SearchEngine service. Pubspec files will be fixed before commit. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2053 lines, -3921 lines) Patch
M pkg/analysis_services/lib/search/search_engine.dart View 4 chunks +59 lines, -74 lines 0 comments Download
M pkg/analysis_services/lib/src/index/index_contributor.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/analysis_services/lib/src/index/store/codec.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_services/lib/src/search/search_engine.dart View 1 chunk +446 lines, -1217 lines 0 comments Download
M pkg/analysis_services/pubspec.yaml View 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/analysis_services/test/index/abstract_single_unit.dart View 1 chunk +93 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/index/dart_index_contributor_test.dart View 77 chunks +615 lines, -444 lines 0 comments Download
M pkg/analysis_services/test/index/store/codec_test.dart View 2 chunks +76 lines, -38 lines 0 comments Download
M pkg/analysis_services/test/search/search_engine_test.dart View 1 chunk +647 lines, -2132 lines 0 comments Download
A + pkg/analysis_services/test/search/test_all.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_services/test/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_testing/lib/mock_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_testing/lib/mocks.dart View 2 chunks +89 lines, -0 lines 0 comments Download
M pkg/analysis_testing/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-10 22:11:18 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-10 22:52:33 UTC) #2
scheglov
6 years, 5 months ago (2014-07-11 02:22:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698