Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 38233004: Temporarily disable TouchList constructor to implement varargs. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Temporarily disable TouchList constructor to implement varargs. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_TouchList.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
I'll work on adding varargs support, but in the meanwhile, I'll get the bots green.
7 years, 2 months ago (2013-10-23 22:30:06 UTC) #1
vsm
lgtm
7 years, 2 months ago (2013-10-23 22:43:24 UTC) #2
Emily Fortuna
7 years, 2 months ago (2013-10-23 22:46:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698