Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 382073002: Mark test as failing. (Closed)

Created:
6 years, 5 months ago by floitsch
Modified:
6 years, 5 months ago
Reviewers:
ricow1, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/co19/co19-dart2dart.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
TBR.
6 years, 5 months ago (2014-07-10 22:07:48 UTC) #1
floitsch
You removed that line in commit r38113.
6 years, 5 months ago (2014-07-10 22:08:14 UTC) #2
floitsch
Committed patchset #1 manually as r38135 (presubmit successful).
6 years, 5 months ago (2014-07-10 22:08:34 UTC) #3
sigurdm
lgtm. r38113 made several tests pass on dart2dart for both backends. This test stopped failing ...
6 years, 5 months ago (2014-07-11 07:00:31 UTC) #4
ricow1
dbc, this is not failing on the new backend, so we should guard this suppression ...
6 years, 5 months ago (2014-07-11 07:09:25 UTC) #5
sigurdm
6 years, 5 months ago (2014-07-11 07:14:40 UTC) #6
Message was sent while issue was closed.
I will do that.

Powered by Google App Engine
This is Rietveld 408576698