Improve wrapping during formatting.

Improve wrapping during formatting.

It will wrap on spaces with the lowest priority first, and if required - on the next priority, etc.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38109

[Brian Wilkerson, 2014-07-09 19:47:16]

LGTM

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/formatter_impl.dart:1633: leadingSpaces += n;
Looks like we need to format this code :-)

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:269: int findMinSpaceWeight() {
This seems really inefficient. And what happens if there are no space tokens?
How about:

int minWeight = UNBREAKABLE_SPACE_WEIGHT;
for (var token in tokens) {
  if (token is SpaceToken) {
    minWeight = min(minWeight, token.breakWeight);
  }
}
return minWeight;

[scheglov, 2014-07-09 20:01:41]

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/writer.dart (right):

https://codereview.chromium.org/381663004/diff/20001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/writer.dart:269: int findMinSpaceWeight() {
On 2014/07/09 19:47:15, Brian Wilkerson wrote:
> This seems really inefficient. And what happens if there are no space tokens?
> How about:
> 
> int minWeight = UNBREAKABLE_SPACE_WEIGHT;
> for (var token in tokens) {
>   if (token is SpaceToken) {
>     minWeight = min(minWeight, token.breakWeight);
>   }
> }
> return minWeight;

Ouch... Forgot to optimize it.
Thanks!

[pquitslund, 2014-07-09 21:14:19]

LGTM.

Nice! :)

[scheglov, 2014-07-09 22:26:34]

Committed patchset #3 manually as r38109 (presubmit successful).