Issue 381543002: Tweaks for speed in integer arithmetic runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381543002: Tweaks for speed in integer arithmetic runtime. (Closed)

Created:
6 years, 5 months ago by regis

Modified:
6 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Tweaks for speed in integer arithmetic runtime. Unrelated: Removed annoying svn property on utils.cc (indicated by MM): svn propdel svn:eol-style runtime/platform/utils.cc R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38090

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -45 lines)			Patch
M	runtime/lib/integers.cc	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
MM	runtime/platform/utils.cc	View		1 chunk	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View		3 chunks	+36 lines, -36 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/381543002/diff/1/runtime/lib/integers.cc File runtime/lib/integers.cc (right): https://codereview.chromium.org/381543002/diff/1/runtime/lib/integers.cc#newcode288 runtime/lib/integers.cc:288: } s/int/intptr_t/

6 years, 5 months ago (2014-07-09 17:05:16 UTC) #2

regis

Thanks! https://codereview.chromium.org/381543002/diff/1/runtime/lib/integers.cc File runtime/lib/integers.cc (right): https://codereview.chromium.org/381543002/diff/1/runtime/lib/integers.cc#newcode288 runtime/lib/integers.cc:288: } On 2014/07/09 17:05:16, srdjan wrote: > s/int/intptr_t/ ...

6 years, 5 months ago (2014-07-09 17:15:51 UTC) #3

regis

6 years, 5 months ago (2014-07-09 17:16:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38090 (presubmit successful).

Expand Messages | Collapse Messages