Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 38113004: Eliminate deprecated Int32/Int64.fromInt() constructors (Closed)

Created:
7 years, 2 months ago by Chris Bracken
Modified:
7 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate deprecated Int32/Int64.fromInt() constructors BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M pkg/fixnum/lib/fixnum.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/fixnum/lib/src/int32.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/fixnum/lib/src/int64.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/fixnum/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Bracken
7 years, 2 months ago (2013-10-23 23:35:21 UTC) #1
sra1
lgtm
7 years, 2 months ago (2013-10-24 00:11:47 UTC) #2
Chris Bracken
7 years, 1 month ago (2013-10-24 20:18:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698